Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor/PN-13453 - Domicile Banner and Validating PEC #1475

Merged
merged 47 commits into from
Feb 24, 2025

Conversation

mflauti
Copy link
Collaborator

@mflauti mflauti commented Feb 18, 2025

Short description

This PR includes the changes needed to make pf and pg webapps follow the last Digital Domicile specifications

List of changes proposed in this pull request

  • session persistence for the user choice to close the digital domicile banner
  • restore the scroll feature when the user clicks on add/enable email and appIO on the banner
  • change the Validating Pec Banner behaviour
  • fix tests

mflauti and others added 30 commits December 6, 2024 09:09
test: add tests to verify DefaultDigitalContact new features
test: fix tests not working after changes to DefaultDigitalContact
test: add code to verify the error message is shown submitting an empty DefaultDigitalContact
…generic, renaming to PnInfoCard and moving to pn-commons

test: fix tests for DigitalContactsCard after refactor
test: add tests for PnInfoCard new functionalities
…draft)

fix: add useEffect to PnInfoCard to refresh expanded/collapsed initial state
… instances

refactor: add rest prop to PnInfoCard
refactor: change LegalContacts layout while validating PEC
test: fix LegalContacts, SpecialContacts and Contacts.page tests
chore: fix LegalContacts translations
… PG)

refactor: change DeleteDialog to reflect new figma specs (PF and PG)
refactor: change some localization keys to simplify LegalContacts code (PF and PG)
test: fix tests which stop working after localization key changed
…al domicile

test: add code to verify DeleteDialog content while disabling digital domicile
mflauti and others added 13 commits January 20, 2025 15:59
refactor: prevent user from accessing digital domicile management page if ddom is not set
feat: add usePreviousLocation hook to manage navigate to previous page replacing history
refactor: change DigitalContactActivation to include EmailSmsContactWizard
refactor: add new optional showLabelOnEdit to DigitalContact component
refactor: now PnWizard component accepts a callback to handle the exit
test: add/change tests for DigitalContactActivation component
…her customize their layout and behaviour

test: add and change tests after adding onExit prop on PnWizard
@mflauti mflauti changed the base branch from develop to feature/rework_contacts February 18, 2025 14:43
@AndreaCimini90 AndreaCimini90 self-assigned this Feb 18, 2025
Copy link
Contributor

@AndreaCimini90 AndreaCimini90 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Before merging, do a check on the all externalEvents that there were before the rework. Check if something was lost

@AndreaCimini90 AndreaCimini90 merged commit 30cbd6d into feature/rework_contacts Feb 24, 2025
5 checks passed
@AndreaCimini90 AndreaCimini90 deleted the refactor/PN-13453 branch February 24, 2025 08:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants