-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor/PN-13453 - Domicile Banner and Validating PEC #1475
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
test: add tests to verify DefaultDigitalContact new features
test: fix tests not working after changes to DefaultDigitalContact test: add code to verify the error message is shown submitting an empty DefaultDigitalContact
…generic, renaming to PnInfoCard and moving to pn-commons test: fix tests for DigitalContactsCard after refactor test: add tests for PnInfoCard new functionalities
…draft) fix: add useEffect to PnInfoCard to refresh expanded/collapsed initial state
… instances refactor: add rest prop to PnInfoCard refactor: change LegalContacts layout while validating PEC test: fix LegalContacts, SpecialContacts and Contacts.page tests chore: fix LegalContacts translations
… PG) refactor: change DeleteDialog to reflect new figma specs (PF and PG) refactor: change some localization keys to simplify LegalContacts code (PF and PG)
test: fix tests which stop working after localization key changed
…al domicile test: add code to verify DeleteDialog content while disabling digital domicile
refactor: prevent user from accessing digital domicile management page if ddom is not set
feat: add usePreviousLocation hook to manage navigate to previous page replacing history
refactor: change DigitalContactActivation to include EmailSmsContactWizard refactor: add new optional showLabelOnEdit to DigitalContact component refactor: now PnWizard component accepts a callback to handle the exit test: add/change tests for DigitalContactActivation component
…her customize their layout and behaviour test: add and change tests after adding onExit prop on PnWizard
2569a02
to
89d87ff
Compare
AndreaCimini90
requested changes
Feb 19, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Before merging, do a check on the all externalEvents that there were before the rework. Check if something was lost
packages/pn-personafisica-webapp/src/components/DomicileBanner/DomicileBanner.tsx
Outdated
Show resolved
Hide resolved
packages/pn-personafisica-webapp/src/components/DomicileBanner/DomicileBanner.tsx
Outdated
Show resolved
Hide resolved
packages/pn-personafisica-webapp/src/components/DomicileBanner/__test__/DomicileBanner.test.tsx
Show resolved
Hide resolved
packages/pn-personagiuridica-webapp/src/components/DomicileBanner/DomicileBanner.tsx
Show resolved
Hide resolved
...es/pn-personagiuridica-webapp/src/components/DomicileBanner/__test__/DomicileBanner.test.tsx
Show resolved
Hide resolved
AndreaCimini90
approved these changes
Feb 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Short description
This PR includes the changes needed to make pf and pg webapps follow the last Digital Domicile specifications
List of changes proposed in this pull request